Adding uniqueItems property to Set schemas
#3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghik
force-pushed
the
set-schema-unique-items
branch
from
8ae4e10 to
d579f40
Compare
ghik
commented
Mar 14, 2024
| @@ -301,6 +301,8 @@ object Schema extends LowPrioritySchema with SchemaCompanionMacros { | |||
| implicit def schemaForOption[T: Schema]: Schema[Option[T]] = implicitly[Schema[T]].asOption | |||
| implicit def schemaForArray[T: Schema]: Schema[Array[T]] = implicitly[Schema[T]].asArray | |||
| implicit def schemaForIterable[T: Schema, C[X] <: Iterable[X]]: Schema[C[T]] = implicitly[Schema[T]].asIterable[C] | |||
| implicit def schemaForSet[T: Schema, C[X] <: scala.collection.Set[X]]: Schema[C[T]] = | |||
There was a problem hiding this comment.
This relies on Scala implicit priority rules, specifically the fact that schemaForSet is "more specific" than schemaForIterable. It seems to work fine in tests, but I always feel a bit anxious when I need to rely on these rules, and in this case it seems to be the first implicit definition to do so.
I just hope we don't introduce some crazy implicit ambiguities into tapir user's projects...
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3441
Requires softwaremill/sttp-apispec#148